Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pester migration - Second batch #9530

Merged
merged 29 commits into from
Oct 26, 2024
Merged

Pester migration - Second batch #9530

merged 29 commits into from
Oct 26, 2024

Conversation

potatoqualitee
Copy link
Member

No description provided.

@potatoqualitee
revert to re-fix
8b93039
@potatoqualitee
update instructions to be a little shorter
c4bcd7b
@potatoqualitee
follow slightly new format
43ce0a5
@potatoqualitee
uncomment skipper
7c61359
@potatoqualitee
Update tests
69b7dc3
@potatoqualitee
fix param checker - we will be checking for whatif and confirm
fca2562
@potatoqualitee
shorten var, fix test
b5be793
@potatoqualitee
lez see
a09937f
@potatoqualitee
move param test
664904e
@potatoqualitee
fix failures
a6958ca
@potatoqualitee
one change
eaabf51
@potatoqualitee
ReorgParams
ebe6660 
Repair-SmallThing -Type ReorgParamTest -First 30
@potatoqualitee
i dunno
8e085ac
@potatoqualitee
maybe
a92e29f
@potatoqualitee
trying to get it to work locally
9ac5114
@potatoqualitee
who knows, im about to skip it
e48f744
@potatoqualitee
add defaults
3c085e6
@potatoqualitee
move things
4e85fba
@potatoqualitee
add defaults
b3f5560
@potatoqualitee
move it back to top, expected is needed for the foreach
03d1cc6
@potatoqualitee
aider cleanup
2e02db1
@potatoqualitee
fix test
244e129 
No idea why this happens:

$results | ForEach-Object { $PSItem.Count }
0
1
0
1
@potatoqualitee
it should just be skipped, it shouldnt try to bring over the notifica…
720dc05 
…tion too
@potatoqualitee
that test got all kinds of messed up
f23f7c6
@potatoqualitee
oops, forgot to actually run the code (do Add-DbaPfDataCollectorCounter)
2339c66
@potatoqualitee
fix scope
e26b8b7
@potatoqualitee
fix scope
881bfc2
@potatoqualitee
fix prompt
ffddf03
@potatoqualitee
turns out the scoping was right all along
addd41f
@potatoqualitee potatoqualitee merged commit f2d3146 into development Oct 26, 2024
13 checks passed
@potatoqualitee potatoqualitee deleted the secondbatch branch October 26, 2024 22:00
@potatoqualitee potatoqualitee restored the secondbatch branch October 26, 2024 22:01
@potatoqualitee potatoqualitee deleted the secondbatch branch October 26, 2024 22:01
@potatoqualitee potatoqualitee restored the secondbatch branch October 27, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@potatoqualitee